Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #13572 || AutoComplete showClear close icon overlap with loader icon #13574

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: #13572 || AutoComplete showClear close icon overlap with loader icon #13574

merged 1 commit into from
Aug 30, 2023

Conversation

ashikjs
Copy link
Contributor

@ashikjs ashikjs commented Aug 30, 2023 •
edited
Loading

Fix || #13572

I just add condition !loaderto show close icon so close or clear icon will not show if is loading.

@vercel
Copy link

vercel bot commented Aug 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 6:20am

@ashikjs
Copy link
Contributor Author

ashikjs commented Aug 30, 2023

@SoyDiego and @gucal hi, can you please check this PR. Thanks advance

@SoyDiego
Copy link
Contributor

@SoyDiego and @gucal hi, can you please check this PR. Thanks advance

Please @ashikjs don't tag me in your PR. Always I check the things.
I'm not part of PrimeNG Team, only a contributor but I cannot accept PRs.
And again, please add "Fix #YourIssueNumber" in your PR to link the PR to the issue and when PrimeNG Team approves, the issue will close automatically too.

Thanks

@ashikjs
Copy link
Contributor Author

ashikjs commented Aug 30, 2023

@SoyDiego Thanks for your advice and I am understand your point.

@ashikjs
Copy link
Contributor Author

ashikjs commented Aug 30, 2023

@mertsincan hi, can you please check this PR. Thanks in advance.

@SoyDiego
Copy link
Contributor

SoyDiego commented Aug 30, 2023 •
edited
Loading

@SoyDiego Thanks for your advice and I am understand your point.

Is in your first message, not in your title and without double points: "Fix #YourIssueNumber"
For example:

image

@ashikjs
Copy link
Contributor Author

ashikjs commented Aug 30, 2023

oh! ya, now understand. @SoyDiego Thanks again.

@mertsincan mertsincan linked an issue Aug 30, 2023 that may be closed by this pull request
AutoComplete showClear close icon overlap with loader icon #13572
Closed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

@mertsincan mertsincan merged commit d5f7ea5 into primefaces:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoyDiego SoyDiego SoyDiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoComplete showClear close icon overlap with loader icon
3 participants
@ashikjs @SoyDiego @mertsincan